gh-138890: Forbidden to suggest builtins name when NameError raised from deleting a name#140813
Closed
Locked-chess-official wants to merge 4 commits intopython:mainfrom
Closed
gh-138890: Forbidden to suggest builtins name when NameError raised from deleting a name#140813Locked-chess-official wants to merge 4 commits intopython:mainfrom
Locked-chess-official wants to merge 4 commits intopython:mainfrom
Conversation
Locked-chess-official
requested review from
iritkatriel and
markshannon
as code owners
Contributor
Author
|
Very surprised. On my windows computer the |
Contributor
Author
|
See the other solution. The way there is better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid that the suggestion in
del nextanddel anextpoint to each other, it needs an attribute for_compute_suggestion_errorto use. When NameError raised from deleting a name, the builtins names shouldn't be contained in the suggestion list.